[PM-13706] Add repository + stored procedures for private key regeneration #4898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomas-Avery
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4898 +/- ##
==========================================
- Coverage 42.17% 42.15% -0.03%
==========================================
Files 1377 1380 +3
Lines 64419 64460 +41
Branches 5915 5917 +2
==========================================
+ Hits 27170 27171 +1
- Misses 36026 36066 +40
Partials 1223 1223 ☔ View full report in Codecov by Sentry. |
|
New Issues
Fixed Issues
|
mzieniukbw
requested changes
Oct 16, 2024
src/Infrastructure.Dapper/KeyManagement/Repositories/UserAsymmetricKeysRepository.cs
Outdated
Show resolved
Hide resolved
mzieniukbw
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13706
📔 Objective
The purpose of this PR is to add the database stored procedure and repository layer for the private key regeneration project.
This initial phase will only target users not in organizations and without emergency access setup.
In future PRs, the database operations will expand to handle these cases.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes